Patch for Friend function linkage check (PR 15841)

Weiming Zhao weimingz at codeaurora.org
Thu Apr 25 12:57:14 PDT 2013


One minor suggest:
In the test case, could you let the friend function access a private member to make sure it works properly?

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

-----Original Message-----
From: Rafael EspĂ­ndola [mailto:rafael.espindola at gmail.com] 
Sent: Thursday, April 25, 2013 12:06 PM
To: John McCall
Cc: Weiming Zhao; Richard Smith; llvm cfe
Subject: Re: Patch for Friend function linkage check (PR 15841)

> I'd just tweak the loop immediately above to separately remember the 
> DC to declare the entity in.

New patch attached.

> John.

Thanks,
Rafael





More information about the cfe-commits mailing list