[PATCH] Fix SemaTemplate/example-dynarray.cpp to use explicit declaration of malloc, free and assert.

Douglas Gregor dgregor at apple.com
Wed Apr 24 11:14:37 PDT 2013


On Apr 23, 2013, at 9:01 AM, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:

> This test looks really odd. It seems designed to be an execution test
> (has a main function, uses assert), but we only produce IL from it. It
> has been odd since it was added in r72437.
> 
> Douglas, what was the intent of this test? Should it be moved to the
> llvm-testsuite where it will actually be executed?

This test can simply be removed. It's not adding any value.

	- Doug

> On 23 April 2013 11:44, Jyotsna Verma <jverma at codeaurora.org> wrote:
>> The attached patch modifies SemaTemplate/example-dynarray.cpp test to have
>> explicit declaration for malloc, free and assert functions and removes its
>> dependency on <stdlib.h> and <assert.h>.
>> 
>> 
>> 
>> Please let me know if the patch is okay to commit.
>> 
>> 
>> 
>> Thanks,
>> 
>> Jyotsna
>> 
>> 
>> 
>> --
>> 
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
>> The Linux Foundation
>> 
>> 
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130424/10e5b254/attachment.html>


More information about the cfe-commits mailing list