[PATCH] StringRef-izing some of clang-check
silvas at purdue.edu
Wed Apr 24 07:11:29 PDT 2013
On Tue, Apr 23, 2013 at 11:36 PM, Christopher Jones <
chrisjones.lambda at gmail.com> wrote:
> Thanks a lot, Sean. I'll keep that in mind like you suggested earlier.
> Is my patch good? Or do I need to do more? : )
It looks fine. Keeping changes small and focused is good. That's a big part
of LLVM development style: small, focused changes, with good justification
that makes them easy to review. (the other major pillar of LLVM development
style is excellent testing, but changes like these with no functionality
change don't need tests).
I'd also like to emphasize that the ArrayRef-ization is really a *much*
more important project. Every time you see pointer+length being passed as
arguments, you can basically indiscriminately replace it with ArrayRef (or
MutableArrayRef if it needs to be mutable). It's a huge win in virtually
-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits