popizdeh at gmail.com
Wed Apr 24 00:26:33 PDT 2013
But won't you have to change this code if you change the docs to say
"returns zero if the set contains the specified cursor"
CXCursorSet_Impl *setImpl = unpackCXCursorSet(set);
On Wed, Apr 24, 2013 at 5:20 PM, Ted Kremenek <kremenek at apple.com> wrote:
> The comments in the PR were to keep the function, so I won't rip it out.
> That said, if there are clients, I'd prefer we change the documentation,
> not the behavior of the code itself.
> On Apr 23, 2013, at 11:48 PM, Ted Kremenek <kremenek at apple.com> wrote:
> Thanks Nikola. This PR and patch made me go back and re-evaluate the
> purpose and need for this function. I don't think there are any clients of
> CXCursorSet, so I think I will just remove it entirely.
> Thanks for investigating this.
> On Apr 22, 2013, at 2:12 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote:
> I was going through bugizilla when I ran into this one
> http://llvm.org/bugs/show_bug.cgi?id=10124 Bug and patch look good but I
> wanted to double check if this is OK to commit and close?
> CCing Ted since he seems to be the author of the function.
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits