[PATCH] OpenMP parallel directive

Dmitri Gribenko gribozavr at gmail.com
Mon Apr 22 06:49:08 PDT 2013



================
Comment at: lib/Basic/OpenMPKinds.cpp:63-64
@@ +62,4 @@
+    return "threadprivate or thread local";
+  default:
+    break;
+  }
----------------
Alexey Bataev wrote:
> Dmitri Gribenko wrote:
> > 'default' should not be needed -- here and in other functions in this file.
> There is NUM_OPENMP_CLAUSES, which is not covered. Should I include it explicitly into the switch?
Oh, I see.  Then it is up to you -- I don't remember any precedents of doing it one way or another.


http://llvm-reviews.chandlerc.com/D572



More information about the cfe-commits mailing list