r179915 - [analyzer] Flip printPretty and printPrettyAsExpr as per suggestion from Jordan (r179572)

Anna Zaks ganna at apple.com
Fri Apr 19 18:15:37 PDT 2013


Author: zaks
Date: Fri Apr 19 20:15:36 2013
New Revision: 179915

URL: http://llvm.org/viewvc/llvm-project?rev=179915&view=rev
Log:
[analyzer] Flip printPretty and printPrettyAsExpr as per suggestion from Jordan (r179572)

Modified:
    cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
    cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp

Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h?rev=179915&r1=179914&r2=179915&view=diff
==============================================================================
--- cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h (original)
+++ cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h Fri Apr 19 20:15:36 2013
@@ -884,7 +884,7 @@ public:
     return R->getKind() == VarRegionKind;
   }
 
-  bool canPrintPretty() const;
+  bool canPrintPrettyAsExpr() const;
 
   void printPrettyAsExpr(raw_ostream &os) const;
 };
@@ -965,7 +965,7 @@ public:
   const ObjCIvarDecl *getDecl() const;
   QualType getValueType() const;
 
-  bool canPrintPretty() const;
+  bool canPrintPrettyAsExpr() const;
   void printPrettyAsExpr(raw_ostream &os) const;
 
   void dumpToStream(raw_ostream &os) const;

Modified: cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp?rev=179915&r1=179914&r2=179915&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Core/MemRegion.cpp Fri Apr 19 20:15:36 2013
@@ -555,11 +555,11 @@ void StackLocalsSpaceRegion::dumpToStrea
 }
 
 bool MemRegion::canPrintPretty() const {
-  return false;
+  return canPrintPrettyAsExpr();
 }
 
 bool MemRegion::canPrintPrettyAsExpr() const {
-  return canPrintPretty();
+  return false;
 }
 
 void MemRegion::printPretty(raw_ostream &os) const {
@@ -575,7 +575,7 @@ void MemRegion::printPrettyAsExpr(raw_os
   return;
 }
 
-bool VarRegion::canPrintPretty() const {
+bool VarRegion::canPrintPrettyAsExpr() const {
   return true;
 }
 
@@ -583,7 +583,7 @@ void VarRegion::printPrettyAsExpr(raw_os
   os << getDecl()->getName();
 }
 
-bool ObjCIvarRegion::canPrintPretty() const {
+bool ObjCIvarRegion::canPrintPrettyAsExpr() const {
   return true;
 }
 





More information about the cfe-commits mailing list