[PATCH] Do not attach a debug location to code inserted by ARC / API for disabling DebugLocations

[Adrian Prantl]

On Apr 15, 2013, at 11:53 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Mon, Apr 8, 2013 at 3:07 PM, Adrian Prantl <aprantl at apple.com> wrote:
>> 
>> Hi Eric,
>> 
>> On Apr 8, 2013, at 1:23 PM, Eric Christopher <echristo at gmail.com> wrote:
>> 
>>> So, since you didn't respond to the rest, these are the similar bugs I
>>> was speaking about:
>>> 
>>> http://llvm.org/bugs/show_bug.cgi?id=14498
>>> http://llvm.org/bugs/show_bug.cgi?id=14580
>>> 
>>> with a little bit due to:
>>> 
>>> http://llvm.org/bugs/show_bug.cgi?id=14610
>>> http://llvm.org/bugs/show_bug.cgi?id=14473
>> 
>> Great! I was hesitant to answer to the rest before I knew more about those PRs :-)
>> 
>>> 
>>> Before we go forward with this I'd like to discuss the general
>>> applicability here for line information.
>> 
>> Sure. My argument for the ARC case is that there is no sensible source line to associate calls to ARC runtime functions (that are mostly transparent to the programmer) with.
>> 


I’ve updated the patches to address all comments I’ve got so far. 
The patch removes line table entries associated with code inserted by ARC, on the basis that there is no useful line to point to.

Apart from that, we should definitely come to a consensus on how closely we want to follow GCC’s line table output and/or the GDB testsuite’s expectations. I think we might be able to discuss this in a thread separate from the review of this patch (especially since there is no GCC example to follow for ARC)?

thanks for all the input so far,
adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Provide-an-API-to-temporarily-suppress-DebugLocation.patch
Type: application/octet-stream
Size: 1863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130419/9704f9d6/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-a-more-idiomatic-way-to-disable-debug-locations.patch
Type: application/octet-stream
Size: 1107 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130419/9704f9d6/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Do-not-attach-a-line-number-to-ARC-specific-cleanup-.patch
Type: application/octet-stream
Size: 3929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130419/9704f9d6/attachment-0002.obj>
-------------- next part --------------