r179771 - Dropped the parentheses for #pragma message and its kin in the -E output generator.

Andy Gibbs andyg1001 at hotmail.co.uk
Fri Apr 19 10:40:47 PDT 2013

On Friday, April 19, 2013 12:12 AM, Jordan Rose wrote:
> On Apr 18, 2013, at 11:54 , Andy Gibbs wrote:
>> On Thursday, April 18, 2013 8:10 PM, Jordan Rose wrote:
>>> I'm okay with not really striving for source fidelity here; since
>>> there's no #pragma GCC message, it's probably safe to just
>>> parenthesize message all the time.
>> So... I'll roll back that particular change, shall I?  I don't think
>> there is much advantage to passing down whether the #pragma was
>> parenthesized or not -- additional overhead for negligible gain IMHO.
> The particular change is that "#pragma GCC warning" should not
> have parentheses, because GCC would choke on that.

Done as requested: r179862.


More information about the cfe-commits mailing list