[PATCH] Avoid SAL names like __in or __out in clang's builtin headers

Hans Wennborg hans at chromium.org
Fri Apr 19 02:22:03 PDT 2013

Hi Reid,

On Thu, Apr 18, 2013 at 4:27 PM, Reid Kleckner <rnk at google.com> wrote:
> The include stack defining __in is:
> xmmintrin.h
> includes mm_malloc.h
> includes stdlib.h (comes from MSVC)
> includes crtdefs.h
> includes sal.h
> which defines __in as nothing
> This is already tested by Modules/compiler_builtins.m, and this
> removes the XFAIL.

LGTM. Maybe flesh out the commit message a bit for those of us who're
not familiar with SAL :)


More information about the cfe-commits mailing list