r179709 - Fix off-by-one error in #pragma clang system_header.

Andy Gibbs andyg1001 at hotmail.co.uk
Wed Apr 17 12:23:13 PDT 2013

On Wednesday, April 17, 2013 9:09 PM, Jordan Rose wrote:
> Author: jrose
> Date: Wed Apr 17 14:09:18 2013
> New Revision: 179709
> URL: http://llvm.org/viewvc/llvm-project?rev=179709&view=rev
> Log:
> Fix off-by-one error in #pragma clang system_header.
> The system_header pragma (from GCC) is implemented using line notes in the
> source manager. However, a line note's line number specifies the number
> not for the current line, but for the next line. This was making all
> line numbers appear off by one after the pragma.
> Reported by Andy Gibbs, uncovered during r179677.

Great, I'll mark the PR as resolved.



More information about the cfe-commits mailing list