[libcxx] r179609 - Added extra space to end of EXTRA_FLAGS in buildit. This fixes http://llvm.org/bugs/show_bug.cgi?id=15761

[Howard Hinnant]

That would work for me too.  On my personal testing this change neither fixed nor caused any problems on Apple.

Howard

On Apr 17, 2013, at 1:01 PM, Dave Zarzycki <zarzycki at apple.com> wrote:

> Shouldn’t the extra space be put here:
> 
> @@ -59,7 +59,7 @@ case $TRIPLE in
>     else
>         if [ -n "$SDKROOT" ]
>         then
> -            EXTRA_FLAGS+="-isysroot ${SDKROOT}"
> +            EXTRA_FLAGS+=" -isysroot ${SDKROOT}"
>             if echo "${RC_ARCHS}" | grep -q "armv7"  
>             then
>                 RE_EXPORT_LINE="${SDKROOT}/usr/lib/libc++abi.dylib -Wl,-reexported_symbols_list,libc++sjlj-abi.exp"
> 
> 
> On Apr 16, 2013, at 10:34 AM, Howard Hinnant <hhinnant at apple.com> wrote:
> 
>> Author: hhinnant
>> Date: Tue Apr 16 12:34:20 2013
>> New Revision: 179609
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=179609&view=rev
>> Log:
>> Added extra space to end of EXTRA_FLAGS in buildit.  This fixes http://llvm.org/bugs/show_bug.cgi?id=15761
>> 
>> Modified:
>>   libcxx/trunk/lib/buildit
>> 
>> Modified: libcxx/trunk/lib/buildit
>> URL: http://llvm.org/viewvc/llvm-project/libcxx/trunk/lib/buildit?rev=179609&r1=179608&r2=179609&view=diff
>> ==============================================================================
>> --- libcxx/trunk/lib/buildit (original)
>> +++ libcxx/trunk/lib/buildit Tue Apr 16 12:34:20 2013
>> @@ -37,7 +37,7 @@ fi
>> 
>> EXTRA_FLAGS="-std=c++0x -fstrict-aliasing -Wall -Wextra -Wshadow -Wconversion \
>>             -Wnewline-eof -Wpadded -Wmissing-prototypes -Wstrict-aliasing=2 \
>> -             -Wstrict-overflow=4"
>> +             -Wstrict-overflow=4 "
>> 
>> case $TRIPLE in
>>  *-apple-*)
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>