[PATCH] Implementing #pragma GCC warning/error
andyg1001 at hotmail.co.uk
Wed Apr 17 09:37:01 PDT 2013
On Tuesday, April 16, 2013 3:51 PM, Douglas Gregor wrote:
> + PragmaMessageHandler(PPCallbacks::PragmaMessageKind Kind,
> + StringRef Namespace = StringRef())
> + : PragmaHandler(PragmaKind(Kind) + 7),
> This "+7" is a bit too magical. Please turn it into a separate function
> with a switch.
> Otherwise, LGTM!
> - Doug
Thanks, I've made the change and it is committed in r179687.
More information about the cfe-commits