[PATCH] Prevent macro argument expansion when the LHS of concatenation is empty

David Blaikie dblaikie at gmail.com
Tue Apr 16 06:41:48 PDT 2013

On Apr 11, 2013 1:43 PM, "Harald van Dijk" <harald at gigawatt.nl> wrote:
> Hi all,
> As mentioned in http://llvm.org/bugs/show_bug.cgi?id=12767, and what I
again reported as http://llvm.org/bugs/show_bug.cgi?id=15661, when
concatenating x ## y, argument expansion for y should be suppressed even
when x is empty. Does this approach look okay? All preprocessor tests pass,
a few other tests were already failing for me and continue to fail the same
way, there are no new failures.
> This is my first contribution to clang, I am not yet familiar with the
process. I should not need to do more than send this patch to the list,

That's the general idea, yes. Assuming your patch includes test cases for
the fix/added functionality.

You may find that code review doesn't happen in a timely manner because
people are busy. It may be necessary to 'ping' (simply by replying to the
thread on the mailing list) to get attention if it seems to have been
forgotten. Any more frequently than weekly would be considered poor form.

> Cheers,
> Harald
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130416/d601adc4/attachment.html>

More information about the cfe-commits mailing list