[PATCH] Fix block comment parser
ruiu at google.com
Tue Apr 16 01:00:11 PDT 2013
Yes, I think the new while-loop is not in a very hot path, as it is
executed only when there's a '/' at the very beginning of a line in a block
comment. And it loops only when previous lines are continuation lines. That
should be pretty unusual. I think that's why this minor bug was not found
until now :)
Can anyone else take a look?
On Tue, Apr 16, 2013 at 4:13 PM, David Blaikie <dblaikie at gmail.com> wrote:
> This looks pretty reasonable to me - but the lexer is a pretty hot
> path (though this doesn't seem like it would be very hot itself) so
> I'm not quite willing to sign off myself, but hopefully this'll be
> brought to someone else's attention at some point
> On Mon, Apr 8, 2013 at 7:16 PM, Rui Ueyama <ruiu at google.com> wrote:
> > Hi,
> > This is my first patch to Clang, and this fixes a bug in block comment
> > parser (http://llvm.org/bugs/show_bug.cgi?id=15706). After submitting
> > patch, Clang will be able to parse the following block comment.
> > /* *\
> > \
> > /
> > Currently Clang can skip only one escaped newline between * and /.
> > Rui
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits