r179131 - Remove outdated run lines from tests.

David Blaikie dblaikie at gmail.com
Tue Apr 16 00:47:34 PDT 2013


On Tue, Apr 9, 2013 at 3:06 PM, Richard Trieu <rtrieu at google.com> wrote:
> Author: rtrieu
> Date: Tue Apr  9 17:06:27 2013
> New Revision: 179131
>
> URL: http://llvm.org/viewvc/llvm-project?rev=179131&view=rev
> Log:
> Remove outdated run lines from tests.
>
> These run lines originally tested that the fix-its were properly applied.
> Originally, the fixits were attached to warnings and were applied by -fixit.
> Now, the fixits are attached to notes, so nothing happens.  These run lines
> still manage to pass since Clang will produce an empty output which gets piped
> back to Clang.

Is that a bug? That seems like a bug.

> Then Clang produces no error on an empty input.
>
> Modified:
>     cfe/trunk/test/Sema/parentheses.c
>     cfe/trunk/test/Sema/parentheses.cpp
>
> Modified: cfe/trunk/test/Sema/parentheses.c
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.c?rev=179131&r1=179130&r2=179131&view=diff
> ==============================================================================
> --- cfe/trunk/test/Sema/parentheses.c (original)
> +++ cfe/trunk/test/Sema/parentheses.c Tue Apr  9 17:06:27 2013
> @@ -1,5 +1,4 @@
>  // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s
> -// RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 -Wparentheses -Werror -
>
>  // Test the various warnings under -Wparentheses
>  void if_assign(void) {
>
> Modified: cfe/trunk/test/Sema/parentheses.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Sema/parentheses.cpp?rev=179131&r1=179130&r2=179131&view=diff
> ==============================================================================
> --- cfe/trunk/test/Sema/parentheses.cpp (original)
> +++ cfe/trunk/test/Sema/parentheses.cpp Tue Apr  9 17:06:27 2013
> @@ -1,5 +1,4 @@
>  // RUN: %clang_cc1 -Wparentheses -fsyntax-only -verify %s
> -// RUN: %clang_cc1 -Wparentheses -fixit %s -o - | %clang_cc1 -Wparentheses -Werror -
>
>  bool someConditionFunc();
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list