r178814 - [analyzer] Reduced the unwanted correlations between checkers living inside MallocChecker.cpp
anton.yartsev at gmail.com
Wed Apr 10 17:07:17 PDT 2013
On 06.04.2013 4:00, Anna Zaks wrote:
> On Apr 4, 2013, at 4:46 PM, Anton Yartsev <anton.yartsev at gmail.com
> <mailto:anton.yartsev at gmail.com>> wrote:
>> + // Used to suppress warnings if they are not related to the
>> tracked family
>> + // (derived from AllocDeallocStmt).
> The comment should focus on what the function does not what it's used
> for. Also, the name is a bit misleading. isTrackedFamily sounds like
> "are we currently tracking this family in the state?".
> Also, let's try to stick to doxygen comments.
>> + bool isTrackedFamily(AllocationFamily Family) const;
>> + bool isTrackedFamily(CheckerContext &C, const Stmt
>> *AllocDeallocStmt) const;
>> + bool isTrackedFamily(CheckerContext &C, SymbolRef Sym) const;
Refactored at r179242.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits