[PATCH] [RFC]TILE-Gx: updated patch for final review

Jiong WANG wong.kwongyuan.llvm at gmail.com
Tue Apr 2 08:04:27 PDT 2013


  on 2013/3/28 0:07, Jiong WANG wrote:
  >    Hi Sean, Joerg,
  >
  >      thanks for your time to review.
  >
  >      I found some of these problems are widely existed on other targets like ARM, Mips etc. For example:
  >
  >    unsigned TileRegisterInfo::getEHExceptionRegister() const {
  >      llvm_unreachable("What is the exception register");
  >    }
  >
  >    it think it's actually dead code.
  >
  >    different backend always borrow code from each other, so those glitches are propagating. TILE-Gx's calling convention implementaion borrowed Mips code, fixed most of these problems on TILE-Gx.
  >
  >      1. rename variable name according to coding style as more as possible.
  >
  >      2. fixed all glitches in regression tests.
  >
  >      3. tried to factor/simplify those code if possible.
  >
  >      please review, thanks.

     Ping.

  ---
  Regards,
  Jiong
  Tilera Corporation.

  >
  >    ---
  >    Regards,
  >    Jiong
  >    Tilera Corporation.
  >
  > http://llvm-reviews.chandlerc.com/D573
  >
  > CHANGE SINCE LAST DIFF
  >    http://llvm-reviews.chandlerc.com/D573?vs=1396&id=1411#toc
  >
  > Files:
  >    include/clang/Basic/TargetInfo.h
  >    lib/AST/ASTContext.cpp
  >    lib/Basic/Targets.cpp
  >    lib/CodeGen/TargetInfo.cpp
  >    lib/Driver/ToolChains.cpp
  >    lib/Driver/Tools.cpp
  >    lib/Driver/Tools.h
  >    autoconf/configure.ac
  >    configure
  >    include/llvm/ADT/Triple.h
  >    include/llvm/MC/MCExpr.h
  >    include/llvm/Object/ELF.h
  >    include/llvm/Object/RelocVisitor.h
  >    include/llvm/Support/ELF.h
  >    lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
  >    lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h
  >    lib/MC/MCExpr.cpp
  >    lib/Support/Triple.cpp
  >    lib/Target/LLVMBuild.txt
  >    lib/Target/Tile/AsmParser/CMakeLists.txt
  >    lib/Target/Tile/AsmParser/LLVMBuild.txt
  >    lib/Target/Tile/AsmParser/Makefile
  >    lib/Target/Tile/AsmParser/TileAsmParser.cpp
  >    lib/Target/Tile/CMakeLists.txt
  >    lib/Target/Tile/InstPrinter/CMakeLists.txt
  >    lib/Target/Tile/InstPrinter/LLVMBuild.txt
  >    lib/Target/Tile/InstPrinter/Makefile
  >    lib/Target/Tile/InstPrinter/TileInstPrinter.cpp
  >    lib/Target/Tile/InstPrinter/TileInstPrinter.h
  >    lib/Target/Tile/LLVMBuild.txt
  >    lib/Target/Tile/MCTargetDesc/CMakeLists.txt
  >    lib/Target/Tile/MCTargetDesc/LLVMBuild.txt
  >    lib/Target/Tile/MCTargetDesc/Makefile
  >    lib/Target/Tile/MCTargetDesc/TileAsmBackend.cpp
  >    lib/Target/Tile/MCTargetDesc/TileBaseInfo.h
  >    lib/Target/Tile/MCTargetDesc/TileELFObjectWriter.cpp
  >    lib/Target/Tile/MCTargetDesc/TileFixupKinds.h
  >    lib/Target/Tile/MCTargetDesc/TileMCAsmInfo.cpp
  >    lib/Target/Tile/MCTargetDesc/TileMCAsmInfo.h
  >    lib/Target/Tile/MCTargetDesc/TileMCCodeEmitter.cpp
  >    lib/Target/Tile/MCTargetDesc/TileMCTargetDesc.cpp
  >    lib/Target/Tile/MCTargetDesc/TileMCTargetDesc.h
  >    lib/Target/Tile/Makefile
  >    lib/Target/Tile/TargetInfo/CMakeLists.txt
  >    lib/Target/Tile/TargetInfo/LLVMBuild.txt
  >    lib/Target/Tile/TargetInfo/Makefile
  >    lib/Target/Tile/TargetInfo/TileTargetInfo.cpp
  >    lib/Target/Tile/Tile.h
  >    lib/Target/Tile/Tile.td
  >    lib/Target/Tile/TileAsmPrinter.cpp
  >    lib/Target/Tile/TileAsmPrinter.h
  >    lib/Target/Tile/TileCallingConv.h
  >    lib/Target/Tile/TileCallingConv.td
  >    lib/Target/Tile/TileExpandPseudo.cpp
  >    lib/Target/Tile/TileFrameLowering.cpp
  >    lib/Target/Tile/TileFrameLowering.h
  >    lib/Target/Tile/TileISelDAGToDAG.cpp
  >    lib/Target/Tile/TileISelLowering.cpp
  >    lib/Target/Tile/TileISelLowering.h
  >    lib/Target/Tile/TileInstrFormats.td
  >    lib/Target/Tile/TileInstrInfo.cpp
  >    lib/Target/Tile/TileInstrInfo.h
  >    lib/Target/Tile/TileInstrInfo.td
  >    lib/Target/Tile/TileMCInst.h
  >    lib/Target/Tile/TileMCInstLower.cpp
  >    lib/Target/Tile/TileMCInstLower.h
  >    lib/Target/Tile/TileMachineFunction.cpp
  >    lib/Target/Tile/TileMachineFunction.h
  >    lib/Target/Tile/TileRegisterInfo.cpp
  >    lib/Target/Tile/TileRegisterInfo.h
  >    lib/Target/Tile/TileRegisterInfo.td
  >    lib/Target/Tile/TileRelocations.h
  >    lib/Target/Tile/TileSchedule.td
  >    lib/Target/Tile/TileSelectionDAGInfo.cpp
  >    lib/Target/Tile/TileSelectionDAGInfo.h
  >    lib/Target/Tile/TileSubtarget.cpp
  >    lib/Target/Tile/TileSubtarget.h
  >    lib/Target/Tile/TileTargetMachine.cpp
  >    lib/Target/Tile/TileTargetMachine.h
  >    lib/Target/Tile/TileVLIWPacketizer.cpp
  >    projects/sample/autoconf/configure.ac
  >    projects/sample/configure
  >    test/CodeGen/Tile/alloca.ll
  >    test/CodeGen/Tile/args.ll
  >    test/CodeGen/Tile/atomic.ll
  >    test/CodeGen/Tile/bswap.ll
  >    test/CodeGen/Tile/ctlz.ll
  >    test/CodeGen/Tile/ctpop.ll
  >    test/CodeGen/Tile/cttz.ll
  >    test/CodeGen/Tile/divrem.ll
  >    test/CodeGen/Tile/fcmp.ll
  >    test/CodeGen/Tile/fdiv.ll
  >    test/CodeGen/Tile/fmul.ll
  >    test/CodeGen/Tile/frame-address.ll
  >    test/CodeGen/Tile/global-address.ll
  >    test/CodeGen/Tile/imm.ll
  >    test/CodeGen/Tile/lit.local.cfg
  >    test/CodeGen/Tile/mul.ll
  >    test/CodeGen/Tile/return-address.ll
  >    test/CodeGen/Tile/select.ll
  >    test/CodeGen/Tile/struct_args.ll
  >    test/CodeGen/Tile/switch-table.ll
  >    test/CodeGen/Tile/tls-models.ll
  >    test/CodeGen/Tile/tls.ll
  >    test/ExecutionEngine/MCJIT/lit.local.cfg
  >    test/MC/Tile/basic-tilegx-instructions.s
  >    test/MC/Tile/lit.local.cfg
  >    test/MC/Tile/pic-symbol.ll
  >    test/MC/Tile/tilegx-bundle.s
  >    test/lit.cfg

http://llvm-reviews.chandlerc.com/D573



More information about the cfe-commits mailing list