[PATCH] [ms-cxxabi] Move MS inheritance model calculation into MemberPointerType

John McCall rjmccall at apple.com
Mon Apr 1 10:46:40 PDT 2013


On Mar 29, 2013, at 4:58 PM, Reid Kleckner <rnk at google.com> wrote:
>  Any thoughts on this?  Is it better to put these methods in AST/MicrosoftCXXABI.cpp or AST/Types.cpp?

Having a convenience method on MemberPointerType makes sense, but I would put the primary implementation on CXXRecordDecl.

Defining both in MicrosoftCXXABI.cpp sounds fine to me.

John.



More information about the cfe-commits mailing list