[libcxx][PATCH] Fix for CMakelists.txt

Michael van der Westhuizen r1mikey at gmail.com
Mon Apr 1 08:59:45 PDT 2013


The destination directory always exists.  See CMakeLists.txt, line 94 (in the setup_abi_lib macro), where each ABI library directory is created at the time CMake is run.

This patch looks good to me, although it's not necessary for the version of CMake I run (2.8.10.1).  I've tested it against all three ABI libraries on Linux with no regression.

Michael

On 01 Apr 2013, at 11:49 AM, G M <gmisocpp at gmail.com> wrote:

> It does work as long as the destination directory already exists.
> But I am thinking it might not work if a file (as opposed to a
> directory) is being copied and the destination directory doesn't exist,
> then I am concerned that what might happen is that cmake is going to copy
> the file and give it the name of the intended directory rather than create
> that directory and copy the file into it.
> I'm no cmake expert, so if anyone agrees who is, could they suggest a fix
> that would prevent that.
> 
> The include directory does already exist in the use case presented so it
> works for that,but other sub-directories might not exist and in those
> circumstances it seems it might fail.
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits





More information about the cfe-commits mailing list