PATCH: Emit lifetime markers under -fsanitize=use-after-scope mode

Nadav Rotem nrotem at apple.com
Mon Apr 1 08:40:09 PDT 2013


Hi Alexey, 

Thanks for the patch. The stack-coloring pass does data flow analysis and it is designed to overcome open lifetime regions. However, it will be a good idea to fix simplifycfg if possible.  The 'use-after-scope' part LGTM. 

Thanks,
Nadav

On Apr 1, 2013, at 3:43 AM, Alexey Samsonov <samsonov at google.com> wrote:

> +cc cfe-commits
> 
> On Mon, Apr 1, 2013 at 2:43 PM, Alexey Samsonov <samsonov at google.com> wrote:
> Hi!
> 
> This patch adds a tiny bit to r177819: it turns on emitting lifetime markers for all auto variables under -fsanitize=use-after-scope mode. LLVM part of this mode is already implemented and adds calls to ASan runtime that mark the memory as addressable before llvm.lifetime.start() and "unaddressable" after llvm.lifetime.end().
> 
> Also note that currently there is a problem with simplifycfg: it may kill llvm.lifetime.start intrinsics at the beginning of some basic blocks. Do you think it may harm you?
> 
> 
> 
> -- 
> Alexey Samsonov, MSK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130401/c21f3386/attachment.html>


More information about the cfe-commits mailing list