[PATCH] [ms-cxxabi] Correctly compute the size of member pointers

Reid Kleckner rnk at google.com
Thu Mar 28 09:27:34 PDT 2013


This patch looks pretty close to done to me.  I started doing more codegen
for these, and I'd like some way to share the code between
lib/AST/MicrosoftCXXABI.cpp and lib/CodeGen/MicrosoftCXXABI.cpp.  In
particular, I want to share the inheritance model computation stuff.  Any
ideas on the best way to do that?

I could add CXXRecordDecl/MemberPointerType::getMSInheritanceModel(), if
that's an OK place to put it.


On Wed, Mar 27, 2013 at 6:38 PM, Reid Kleckner <rnk at google.com> wrote:

>     - Split function member pointer case from data case.
>
> Hi rjmccall,
>
> http://llvm-reviews.chandlerc.com/D568
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D568?vs=1406&id=1416#toc
>
> Files:
>   lib/AST/ASTContext.cpp
>   lib/AST/CXXABI.h
>   lib/AST/ItaniumCXXABI.cpp
>   lib/AST/MicrosoftCXXABI.cpp
>   lib/Sema/SemaType.cpp
>   test/SemaCXX/member-pointer-ms.cpp
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130328/77674238/attachment.html>


More information about the cfe-commits mailing list