[clang-tools-extra] r178207 - modularize - revised to group duplicate symbols together in the error output.

Chandler Carruth chandlerc at google.com
Wed Mar 27 18:34:15 PDT 2013


On Wed, Mar 27, 2013 at 6:20 PM, John Thompson <
John.Thompson.JTSoftware at gmail.com> wrote:

>  struct Entry {
> -  enum Kind {
> +  enum KindType {
>      Tag,
>      Value,
>      Macro
>    } Kind;
> +  static const int NumberOfKinds = 3;
>

Err...

Check out the coding standards for thinks like "kind" enums. I think there
is a much better pattern to follow here:

struct Entry {
  enum EnttryKind {
    EK_Tag,
    EK_Value,
    EK_Macro,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130327/d4fe38fd/attachment.html>


More information about the cfe-commits mailing list