[PATCH] Split line comments

Daniel Jasper djasper at google.com
Tue Mar 26 23:48:23 PDT 2013


  Looks good.


================
Comment at: lib/Format/Format.cpp:174
@@ +173,3 @@
+      splitLineInComment(Tok.FormatTok, Line.substr(Prefix.size()),
+                         StartColumn + Prefix.size(), NewPrefix, false, false);
+    }
----------------
Nit: use "/*InPPDirective=*/ false" and "/*CommentHasMoreLines=*/ false"

================
Comment at: lib/Format/Format.cpp:172
@@ +171,3 @@
+          std::string(StartColumn, ' ') +
+          (Prefix.endswith(" ") ? Prefix.str() : Prefix.str() + " ");
+      splitLineInComment(Tok.FormatTok, Line.substr(Prefix.size()),
----------------
Nit: Add comment explaining why you are doing this.


http://llvm-reviews.chandlerc.com/D577

BRANCH
  svn

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list