[cfe-commits] [Patch] Implement compiler intrinsics for MSVC 2012 type_traits

[Richard Smith]

+++ b/lib/Sema/SemaExprCXX.cpp
@@ -2952,6 +2955,42 @@ static bool CheckUnaryTypeTraitTypeCompleteness(Sema
&S,
[...]
+  CXXRecordDecl* RD = cast<CXXRecordDecl>(RT->getDecl());

Should be " *", not "* ".

+  if((RD->*HasTrivial)() && !(RD->*HasNonTrivial)())
+    return true;

Missing space after 'if'.

+    //  This trait is implemented by MSVC 2012 and needed to parse the
+    //  standard library headers. Specifically this is used as the logic
+    //  behind std::has_trivial_move_constructor (20.9.4.3).

The trait is called std::is_trivial_move_constructible.

Otherwise, LGTM! Thanks for picking this up.

On Fri, Mar 22, 2013 at 4:51 AM, Aaron Ballman <aaron at aaronballman.com>wrote:

> Changes LGTM based on Richard's suggestions.  Waiting to make sure
> Richard agrees.  :-)
>
> ~Aaron
>
> On Thu, Mar 21, 2013 at 10:58 AM, João Matos <ripzonetriton at gmail.com>
> wrote:
> > On Sat, Jan 19, 2013 at 2:12 AM, Richard Smith <richard at metafoo.co.uk>
> > wrote:
> >>
> >> Sorry for the delay! Just a handful of things:
> >
> >
> > Hi Richard, I did the changes you requested.
> >
> > http://llvm-reviews.chandlerc.com/D567
> >
> > --
> > João Matos
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130326/f02046cd/attachment.html>