[PATCH] [RFC]TILE-Gx: updated patch for final review

Sean Silva silvas at purdue.edu
Tue Mar 26 14:55:16 PDT 2013


On Tue, Mar 26, 2013 at 11:24 AM, Joerg Sonnenberger <
joerg at britannica.bec.de> wrote:

> On Mon, Mar 25, 2013 at 10:18:23PM -0700, Jiong WANG wrote:
> >      8. promote variable evaluation in loop body, change code shape like:
> >
> >       for (int i; i < XXX.size(); i++)  to
> >       for (int i, int e = XXX.size(); i< e; i++)
>
> Minor nit, but I think the pre-increment form is generally prefered in
> C++ land.
>
>
>
Also, i != e instead of i < e, since you're only doing forward iteration
here and < implies random access.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130326/902780cd/attachment.html>


More information about the cfe-commits mailing list