[PATCH] Rename LinuxTargetInfo to GNUOrAndroidEnvironmentTargetInfo and handle llvm::Triple::Hurd.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Mon Mar 25 11:02:25 PDT 2013


> +    case llvm::Triple::Hurd:
> +      //DefineStd(Builder, "MACH", Opts);
> +      Builder.defineMacro("__MACH__");
> +      Builder.defineMacro("__gnu_hurd__");
> +      Builder.defineMacro("__GNU__");
> +      break;

Please don't add commented out code. You should also add a test
checking that these macros are defined.

Thanks,
Rafael



More information about the cfe-commits mailing list