r177743 - These tests fail on our Window64 machine.

David Blaikie dblaikie at gmail.com
Fri Mar 22 14:25:46 PDT 2013


On Fri, Mar 22, 2013 at 2:15 PM, jahanian <fjahanian at apple.com> wrote:
> Adding XFAIL:win64 is not effective. I probably need to make other changes
> somewhere else so win64 be recognized.
> I noticed that some tests XFAIL win32. Can some one point me to the proper
> place where additional changes need
> be made.

I expect it shouldn't be too hard to find in the lit code somewhere,
though I've not looked recently.

[side note: I'm not really sure this is an appropriate thing to do, or
at the very least it should be accompanied by a PR (filed & mentioned
next to the xfails) - these failures aren't "expected" for any known
reason (but I'll give you that they're more likely test bugs than
product bugs)]

>
> - Thanks, Fariborz
>
> On Mar 22, 2013, at 10:42 AM, Fariborz Jahanian <fjahanian at apple.com> wrote:
>
> Author: fjahanian
> Date: Fri Mar 22 12:42:39 2013
> New Revision: 177743
>
> URL: http://llvm.org/viewvc/llvm-project?rev=177743&view=rev
> Log:
> These tests fail on our Window64 machine.
> Feel free to revert them (or let me know and I will revert)
> if they shouldn't be.
>
> Modified:
>    cfe/trunk/test/Tooling/auto-detect-from-source-parent-of-cwd.cpp
>    cfe/trunk/test/Tooling/auto-detect-from-source-parent.cpp
>    cfe/trunk/test/Tooling/auto-detect-from-source.cpp
>    cfe/trunk/test/Tooling/clang-check-autodetect-dir.cpp
>    cfe/trunk/test/Tooling/clang-check-pwd.cpp
>
> Modified: cfe/trunk/test/Tooling/auto-detect-from-source-parent-of-cwd.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/auto-detect-from-source-parent-of-cwd.cpp?rev=177743&r1=177742&r2=177743&view=diff
> ==============================================================================
> --- cfe/trunk/test/Tooling/auto-detect-from-source-parent-of-cwd.cpp
> (original)
> +++ cfe/trunk/test/Tooling/auto-detect-from-source-parent-of-cwd.cpp Fri Mar
> 22 12:42:39 2013
> @@ -8,3 +8,4 @@
> invalid;
>
> // REQUIRES: shell
> +// XFAIL: win64
>
> Modified: cfe/trunk/test/Tooling/auto-detect-from-source-parent.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/auto-detect-from-source-parent.cpp?rev=177743&r1=177742&r2=177743&view=diff
> ==============================================================================
> --- cfe/trunk/test/Tooling/auto-detect-from-source-parent.cpp (original)
> +++ cfe/trunk/test/Tooling/auto-detect-from-source-parent.cpp Fri Mar 22
> 12:42:39 2013
> @@ -8,3 +8,4 @@
> invalid;
>
> // REQUIRES: shell
> +// XFAIL: win64
>
> Modified: cfe/trunk/test/Tooling/auto-detect-from-source.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/auto-detect-from-source.cpp?rev=177743&r1=177742&r2=177743&view=diff
> ==============================================================================
> --- cfe/trunk/test/Tooling/auto-detect-from-source.cpp (original)
> +++ cfe/trunk/test/Tooling/auto-detect-from-source.cpp Fri Mar 22 12:42:39
> 2013
> @@ -8,3 +8,4 @@
> invalid;
>
> // REQUIRES: shell
> +// XFAIL: win64
>
> Modified: cfe/trunk/test/Tooling/clang-check-autodetect-dir.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/clang-check-autodetect-dir.cpp?rev=177743&r1=177742&r2=177743&view=diff
> ==============================================================================
> --- cfe/trunk/test/Tooling/clang-check-autodetect-dir.cpp (original)
> +++ cfe/trunk/test/Tooling/clang-check-autodetect-dir.cpp Fri Mar 22
> 12:42:39 2013
> @@ -9,3 +9,4 @@
> invalid;
>
> // REQUIRES: shell
> +// XFAIL: win64
>
> Modified: cfe/trunk/test/Tooling/clang-check-pwd.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Tooling/clang-check-pwd.cpp?rev=177743&r1=177742&r2=177743&view=diff
> ==============================================================================
> --- cfe/trunk/test/Tooling/clang-check-pwd.cpp (original)
> +++ cfe/trunk/test/Tooling/clang-check-pwd.cpp Fri Mar 22 12:42:39 2013
> @@ -9,3 +9,4 @@
> invalid;
>
> // REQUIRES: shell
> +// XFAIL: win64
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



More information about the cfe-commits mailing list