[PATCH] [ms-cxxabi] Implement member data pointers for non-dynamic classes

Reid Kleckner rnk at google.com
Fri Mar 22 11:58:38 PDT 2013

On Fri, Mar 22, 2013 at 1:16 PM, John McCall <rjmccall at apple.com> wrote:

> On Mar 22, 2013, at 9:58 AM, Reid Kleckner <rnk at google.com> wrote:
> On Thu, Mar 21, 2013 at 11:14 PM, John McCall <rjmccall at apple.com> wrote:
>> All these tests are pretty inadequate;  you could be accidentally doing
>>  a lot of stuff besides the stores.  You should basically be testing the
>> entire
>> function body, including the define line.  This will also let you
>> effectively
>> test that you're generating the right IR type, which will be important
>> when
>> you start generating different IR types for different cases.
> OK, now the alloca and its size is part of the test.  That should
> constrain the size of the member pointer to a single slot.
> Might as well use CHECK-NEXT for everything after the first alloca line.

Sure, modulo the labels I omitted around the if lowering.

With that, feel free to commit, thanks!

Thanks for the review!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130322/91a476d2/attachment.html>

More information about the cfe-commits mailing list