[PATCH] Fix for Bug 7256 - clang++ should provide a fix-it hint for incorrect destructor declarations

[Ismail Pazarbasi]

On Wed, Mar 20, 2013 at 6:44 PM, David Blaikie <dblaikie at gmail.com> wrote:
> On Mon, Mar 4, 2013 at 8:13 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>> On Mon, Feb 25, 2013 at 8:48 PM, Ismail Pazarbasi
>> <ismail.pazarbasi at gmail.com> wrote:
>>> On Tue, Feb 19, 2013 at 1:11 AM, Ismail Pazarbasi
>>> <ismail.pazarbasi at gmail.com> wrote:
>>>> On Tue, Feb 19, 2013 at 12:43 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
>>>>> On Tue, Feb 19, 2013 at 1:02 AM, Ismail Pazarbasi
>>>>> <ismail.pazarbasi at gmail.com> wrote:
>>>>> <0001-Fix-for-Bug-7256-clang-should-provide-a-fix-it-hint-.patch>
>>>>>
>>>>> +      if (const CXXRecordDecl* Class = dyn_cast_or_null<CXXRecordDecl>(Ctx))
>>>>>
>>>>> LLVM style is to put space before the star.
>>>>>
>>>>> Dmitri
>>>>>
>>>>> --
>>>>> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
>>>>> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
>>>>
>>>> I have fixed the whitespace issue.
>>>>
>>>> Could you please check whether the patch for the test is correct? I
>>>> have added a line of RUN command/instruction with
>>>> -fdiagnostics-parseable-fixits based on the one in test/FixIt/typo.c.
>>>> I hope I've got that right.
>>>>
>>>> Thanks!
>>>
>>> Ping! Does this look good?
>>
>> Yes, this looks good to me.
>
> Committed on Ismail's behalf in r177546. Thanks for the fix!

Thank you Dmitri and David for review and the commit!