[PATCH] [ms-cxxabi] Fix assertion on unhandled function template arg types
John McCall
rjmccall at apple.com
Tue Mar 19 16:33:51 PDT 2013
On Mar 19, 2013, at 3:55 PM, Reid Kleckner <rnk at google.com> wrote:
> This code was changed in r158376 to get template argument source info
> for better diagnostics, but the current code asserts for any kind of
> unsupported template argument before it can issue a diagnostic. This change
> goes back to the Itanium implementation of isTemplate() and puts the argument
> index into the diagnostic instead of a source location.
Sounds fine. There's no reason to go through heroics for these
unsupported-mangling diagnostics.
John.
More information about the cfe-commits
mailing list