[PATCH] If the user requested a zero-base-shadow sanitizer, infer -pie and -fPIC when appropriate.

Chandler Carruth chandlerc at gmail.com
Tue Mar 19 02:58:08 PDT 2013


  Hmm, still pondering if there is a better way, but generally this is close. One specific comment below.


================
Comment at: lib/Driver/ToolChains.h:505
@@ -501,2 +504,3 @@
   std::vector<std::string> ExtraOpts;
+  bool SanitizerHasZeroBaseShadow;
 
----------------
This doesn't make a huge amount of sense to me... Maybe it would be clearer to call it IsPIEDefault? In particular, it represents both whether there is a sanitizer enabled and whether it is zero-based...


http://llvm-reviews.chandlerc.com/D502

BRANCH
  imply-pie

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list