[PATCH] FreeBSD: Set the ARM EABI version when using an external assembler

Andrew Turner andrew at fubar.geek.nz
Sun Mar 17 23:49:37 PDT 2013


On Sun, 17 Mar 2013 19:39:54 +0000
Renato Golin <renato.golin at linaro.org> wrote:

> On 17 March 2013 19:10, Andrew Turner <andrew at fubar.geek.nz> wrote:
> 
> > > You're changing both EABI and GNUEABI but only testing one of
> > > them.
> > I can add a test for EABI but only GNUEABI will be supported on
> > FreeBSD.
> >
> 
> It's weird, I agree. It should be safe to print version 5 on Clang's
> binaries, since every new release should be backwards compatible, as
> is 5 with the previous.
> 
> 
> How? When using an external assembler the the ABI version is sever
> >
> passed to it so will be 0.
> >
> 
> -Wa?

Yes, I forgot about that. I don't feel this would be a solution as
every user of clang on FreeBSD ARM would need to add this when using
clang.

> Anyhow, I think I agree with Anton that the patch is harmless for most
> cases and beneficial to your case. I can't think of a way where it
> would be bad or break current code, maybe I was just being over
> cautious.
> 
> Feel free to commit.
I am unable to as I am not an LLVM committer.

Andrew



More information about the cfe-commits mailing list