[Patch] Fix redundant comparison in gcc::Common::ConstructJob

Rafael EspĂ­ndola rafael.espindola at gmail.com
Sun Mar 17 15:37:12 PDT 2013

On 17 March 2013 10:52, Hans Wennborg <hans at chromium.org> wrote:
> Hi all,
> I found the suspect expression "Arch == llvm::Triple::x86_64 || Arch
> == llvm::Triple::x86_64" in gcc::Common::ConstructJob. It seems the
> right-hand side used to check for powerpc64, but got lost in a
> refactoring.
> The attached patch fixes this and tries to update the test too.

The patch itself looks good, but if it is not too much to ask, could
you also change test/Driver/unknown-gcc-arch.c to use FileCheck?

> Please take a look!
> Thanks,
> Hans


More information about the cfe-commits mailing list