modularize tests - please review

[Sean Silva]

+# RUN: modularize %s -x c++ 2>&1 | FileCheck %s

2>&1 will confuse the testing infrastructure, which doesn't accept full
bash/sh syntax. See near the bottom of this section:
http://llvm.org/docs/TestingGuide.html#writing-new-regression-tests

+// SomeTypes.h - Define a few different kinds of types - no modules
problems.

You can probably drop the filename. Over time it's unlikely that all of the
added tests will have the filename, so things will gradually become
inconsistent.

+
+typedef int TypeInt;
+
+typedef TypeInt NestedTypeInt;
+
+struct TypeStruct
+{
+  int Member;
+};

Keep the opening curly bracket on the same line as "struct TypeStruct" as
per the LLVM coding conventions. For simplicity, you may want to just run
clang-format on the files.

+# CHECK: error: 'SYMBOL' defined at both
{{.*}}{{\\|/}}InputProblemsInconsistent{{\\|/}}SubHeader.h:3:9 and
{{.*}}{{\\|/}}InputProblemsInconsistent/SubHeader.h:6:9

It seems like other test in tree do {{[/\\]}} instead of {{\\|/}}. Rather
microscopic, but it would be good to be consistent.

-- Sean Silva
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130316/fc7575aa/attachment.html>