r177207 - [analyzer] Address a TODO in the StreamChecker; otherwise the output is non-deterministic.

Anna Zaks ganna at apple.com
Fri Mar 15 16:34:31 PDT 2013


Author: zaks
Date: Fri Mar 15 18:34:31 2013
New Revision: 177207

URL: http://llvm.org/viewvc/llvm-project?rev=177207&view=rev
Log:
[analyzer] Address a TODO in the StreamChecker; otherwise the output is non-deterministic.

Modified:
    cfe/trunk/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/StreamChecker.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/StaticAnalyzer/Checkers/StreamChecker.cpp?rev=177207&r1=177206&r2=177207&view=diff
==============================================================================
--- cfe/trunk/lib/StaticAnalyzer/Checkers/StreamChecker.cpp (original)
+++ cfe/trunk/lib/StaticAnalyzer/Checkers/StreamChecker.cpp Fri Mar 15 18:34:31 2013
@@ -400,9 +400,8 @@ void StreamChecker::checkDeadSymbols(Sym
     SymbolRef Sym = *I;
     ProgramStateRef state = C.getState();
     const StreamState *SS = state->get<StreamMap>(Sym);
-    // TODO: Shouldn't we have a continue here?
     if (!SS)
-      return;
+      continue;
 
     if (SS->isOpened()) {
       ExplodedNode *N = C.generateSink();





More information about the cfe-commits mailing list