r177138 - [analyzer] Refactor checks in IDC visitor for consistency and speed

Jordan Rose jordan_rose at apple.com
Fri Mar 15 09:05:04 PDT 2013


On Mar 14, 2013, at 18:15 , Anna Zaks <ganna at apple.com> wrote:

> +  AnalyzerOptions &Options =
> +  BRC.getBugReporter().getEngine().getAnalysisManager().options;
> +  if (!Options.shouldSuppressInlinedDefensiveChecks())
> +    return 0;

This doesn't need to be checked every time through. It might be easier to wrap up the creation of the visitor in a helper method (like trackNullOrUndef) that just doesn't attach it in the first place if suppressIDC is turned off.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130315/829252c9/attachment.html>


More information about the cfe-commits mailing list