r176942 - Add llvm-symbolizer as test dependency.

[Alexey Samsonov]

On Thu, Mar 14, 2013 at 1:24 AM, Jordan Rose <jordan_rose at apple.com> wrote:

>
> On Mar 13, 2013, at 14:21 , Alexey Samsonov <samsonov at google.com> wrote:
>
> Hi!
>
> On Wed, Mar 13, 2013 at 8:04 PM, Jordan Rose <jordan_rose at apple.com>
> wrote:
>
>> 1) Does this need to be added to the Makefile build as well?
>>
>
> Um, at first glance I can't see how to define that a test suite depends on
> a certain tool…
>
>
> Ah, I guess in Make we just depend on LLVM implicitly being built first.
>
> 2) Should this be conditional on having compiler-rt?
>>
>
> No, llvm-symbolizer doesn't depend on compiler-rt. "ASan or MSan"
> mentioned in
> the commit message are turned on in the compiler flags of host compiler.
>
>
> Oh, the host compiler, not the built compiler. My bad. (If this were more
> expensive, I'd say it should be conditional on building with asan/msan, but
> llvm-symbolizer is light enough that it's fine to have the rest of us
> building it too.)
>

I agree, first part of better support for running under ASan/MSan is being
reviewed at http://llvm-reviews.chandlerc.com/D459. When we have a nice
support in the build system, it would be easy to optionally set
dependencies.


>
> Jordan
>



-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130314/b961f4bd/attachment.html>