r176949 - Refactoring:

Jordan Rose jordan_rose at apple.com
Wed Mar 13 09:10:53 PDT 2013


Thanks for the cleanup!

On Mar 13, 2013, at 7:39 , Anton Yartsev <anton.yartsev at gmail.com> wrote:

> +    if (Interesting)
> +      R->markInteresting(Sym);
> +    R->addVisitor(new MallocBugVisitor(Sym));

This is not the same logic; the previous code tracked both symbols in the case of a realloc:

int *x = malloc(4); // $sym1
int *y = realloc(x, 5); // $sym2
if (y)
	free(x); // use-after-free, should track both symbols.

Sorry we didn't catch that sooner.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130313/de61f613/attachment.html>


More information about the cfe-commits mailing list