[PATCH][Review request] unix.Malloc checker improvement: +handling new/delete, +memory.MismatchedFree, +memory.MismatchedDelete, +improved display names for allocators/deallocators

Jordan Rose jordan_rose at apple.com
Thu Mar 7 17:09:41 PST 2013


On Mar 7, 2013, at 15:53 , Anton Yartsev <anton.yartsev at gmail.com> wrote:

> On 07.03.2013 21:29, Jordan Rose wrote:
>> On Mar 7, 2013, at 4:47 , Anton Yartsev <anton.yartsev at gmail.com> wrote:
>> 
>> Can we just do the Objective-C part first? Can you send that patch too?
> Attached. I'll update the main patch after this one gets in.

Looking at this again, I think the old logic was right (or at least more conservative). It says that any method with "freeWhenDone" in the name can take ownership (if the param is true), and additionally that any method with "NoCopy" and no "freeWhenDone" will also take ownership.

Anna's right that this needs a test case too.
Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130307/cd1828a2/attachment.html>


More information about the cfe-commits mailing list