[PATCH] Address spaced pointers to structs

Benyei, Guy guy.benyei at intel.com
Thu Mar 7 03:38:17 PST 2013


Hi all,
Any remarks on this, or can I go on and commit it? It's quite a small change, and it fixes a painful crash in OpenCL.

Thanks
    Guy
[email_signature_guy_new2]

From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Benyei, Guy
Sent: Thursday, February 28, 2013 15:56
To: cfe-commits at cs.uiuc.edu
Subject: [PATCH] Address spaced pointers to structs

Hi all,
This patch fixes a case, where a memory buffer of structs is located in an address space different from 0, and one of its elements is being passed to a function that expects a non-address spaced struct argument. In this case, the value being passed should be copied to local memory, rather than trying to pass its address in the address spaced memory object, which leads to a failure.

Please review

Thanks
   Guy
[email_signature_guy_new2]

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130307/71aaf50a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.png
Type: image/png
Size: 24800 bytes
Desc: image001.png
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130307/71aaf50a/attachment.png>


More information about the cfe-commits mailing list