[OpenCL patch] vec_type_hint

Joey Gouly joey.gouly at arm.com
Thu Mar 7 03:25:51 PST 2013


Hi Murat,

The code you added in 'lib/CodeGen/CodeGenFunction.cpp' should be changed to
look like the surrounding code.
That is, use a normal array instead of a SmallVector. We don't need a
SmallVector here because we know the size
Is always 3, and cannot grow.

Otherwise LGTM.

Any other comments? Otherwise I will commit this for Murat.

Thanks,
Joey

From: cfe-commits-bounces at cs.uiuc.edu
[mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Murat Bolat
Sent: 06 March 2013 18:04
To: cfe-commits at cs.uiuc.edu
Subject: [OpenCL patch] vec_type_hint

Hi all,

Here is the updated patch for vec_type_hint attribute in OpenCL.
The previous discussion about it:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120813/062502.h
tml

Thanks a lot!
Murat Bolat


-- IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended
recipient, please notify the sender immediately and do not disclose the
contents to any other person, use it for any purpose, or store or copy the
information in any medium. Thank you.







More information about the cfe-commits mailing list