[PATCH] multiple inlining scopes for a single source location

[Adrian Prantl]

On Mar 5, 2013, at 10:00 AM, Eric Christopher <echristo at gmail.com> wrote:

> Hi Adrian,
> 
> Thinking about this I wonder if we might want two EmitLocation routines instead, with one to force the column. Another thought is just to always emit it and ignore it in the backend. Can you take a look at that and see whether it would be better?

I believe one of the original reasons behind removing column info by default is that getColumnNumber() was deemed too expensive to call every time. This would speak against dropping it in the backend.
see also http://llvm.org/bugs/show_bug.cgi?id=14106.

As for created two versions of EmitLocation, I can do that of course, but it seems to be an unnecessary duplication of code to me. What would the benefit be? Is it about the cost of the “hidden" 3rd argument?


> Also please update the comment to not reference internal apple clang versions and instead reference svn revisions (or, instead and better, just describe the changes).

done. (I’ll send out a new patch after we reached a consensus about what to best do with emitLocation()).

thanks,
Adrian