r176453 - Mips specific inline assembler constraint 'R'

[Richard Smith]

On 4 Mar 2013 18:35, "Jack Carter" <jack.carter at imgtec.com> wrote:
>
> Author: jacksprat
> Date: Mon Mar  4 15:36:11 2013
> New Revision: 176453
>
> URL: http://llvm.org/viewvc/llvm-project?rev=176453&view=rev
> Log:
> Mips specific inline assembler constraint 'R'
>
> 'R' An address that can be sued in a non-macro load or store.
> This patch includes a positive test case.
>
>
> Modified:
>     cfe/trunk/lib/Basic/Targets.cpp
>     cfe/trunk/test/CodeGen/mips-constraint-regs.c
>
> Modified: cfe/trunk/lib/Basic/Targets.cpp
> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=176453&r1=176452&r2=176453&view=diff
>
==============================================================================
> --- cfe/trunk/lib/Basic/Targets.cpp (original)
> +++ cfe/trunk/lib/Basic/Targets.cpp Mon Mar  4 15:36:11 2013
> @@ -4486,6 +4486,9 @@ public:
>      case 'x': // hilo register pair
>        Info.setAllowsRegister();
>        return true;
> +    case 'R': // An address tha can be used in a non-macro load or store

Typo

> +      Info.setAllowsMemory();
> +      return true;
>      }
>    }
>
>
> Modified: cfe/trunk/test/CodeGen/mips-constraint-regs.c
> URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGen/mips-constraint-regs.c?rev=176453&r1=176452&r2=176453&view=diff
>
==============================================================================
> --- cfe/trunk/test/CodeGen/mips-constraint-regs.c (original)
> +++ cfe/trunk/test/CodeGen/mips-constraint-regs.c Mon Mar  4 15:36:11 2013
> @@ -2,9 +2,7 @@
>  // RUN: | FileCheck %s
>
>  // This checks that the frontend will accept inline asm constraints
> -// c', 'l' and 'x'. Semantic checking will happen in the
> -// llvm backend. Any bad constraint letters will cause the frontend to
> -// error out.
> +// c', 'l' and 'x'.
>
>  int main()
>  {

Aren't you missing an actual test change here?

>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130304/2191c7ba/attachment.html>