[PATCH] CommandLineArgumentParser: handle single quotes.

[Peter Collingbourne]

On Fri, Mar 01, 2013 at 11:00:25AM +0100, Manuel Klimek wrote:
> On Fri, Mar 1, 2013 at 10:52 AM, Peter Collingbourne <peter at pcc.me.uk>wrote:
> > (More concretely, this feature turned out to be necessary to support
> > chromium's command lines).
> >
> 
> How so?

Gyp uses [1] a whitelist of characters unmodified by the shell to
decide whether an argument needs to be (single) quoted.  If it were
modified to use double quotes (or no quoting) it would need to start
using a blacklist of characters to escape, which would be more risky.

> > >  If we decide we need this, I'd want us to handle escaping of ticks.
> >
> > Do you mean, e.g. '\''? I don't see any mention of escaping of ticks in
> > the POSIX spec (
> > http://pubs.opengroup.org/onlinepubs/009695399/utilities/xcu_chap02.html#tag_02_02_02
> > ).
> >
> 
> You're right. Ok, looks good to me then.

r176404.

Thanks,
-- 
Peter

[1] pylib/gyp/generator/ninja.py, function QuoteShellArgument