[PATCH] Replace loop variable naming logic

Jack Yang jack.yang at intel.com
Fri Mar 1 11:51:37 PST 2013


jy7.yang added you to the CC list for the revision "Replace loop variable naming logic".

Hi klimek,

Instead of naming the new loop variable based on the container name, we
now simply reuse the original loop variable.

The previous way was causing problems when, for example, the container
name is 'ints'. The naming logic checks for plurality, then names the
new loop variable as 'int' which is a reserved keyword.

Changes for loop convert tests are also made; all variable name pattern
matchers are replaced with the actual expected name.

http://llvm-reviews.chandlerc.com/D484

Files:
  cpp11-migrate/LoopConvert/LoopActions.cpp
  cpp11-migrate/LoopConvert/VariableNaming.cpp
  cpp11-migrate/LoopConvert/VariableNaming.h
  docs/cpp11-migrate.rst
  test/cpp11-migrate/Combined/combined.cpp
  test/cpp11-migrate/LoopConvert/array.cpp
  test/cpp11-migrate/LoopConvert/confidence.cpp
  test/cpp11-migrate/LoopConvert/dependency.cpp
  test/cpp11-migrate/LoopConvert/iterator.cpp
  test/cpp11-migrate/LoopConvert/naming.cpp
  test/cpp11-migrate/LoopConvert/nesting.cpp
  test/cpp11-migrate/LoopConvert/pseudoarray.cpp
  test/cpp11-migrate/LoopConvert/single-iterator.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D484.1.patch
Type: text/x-patch
Size: 30574 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130301/3caf76b4/attachment.bin>


More information about the cfe-commits mailing list