PATCH: private ivars - update for r176116

Adrian Prantl aprantl at apple.com
Thu Feb 28 14:38:29 PST 2013


So everybody seems to be ok with the performance. Eric, do you have any opinion on the caching part?

thanks,
Adrian

On Feb 27, 2013, at 2:36 PM, jahanian <fjahanian at apple.com> wrote:

> LGTM.
> - Thanks Fariborz
> 
> On Feb 27, 2013, at 1:55 PM, Adrian Prantl <aprantl at apple.com> wrote:
> 
>> 
>> On Feb 27, 2013, at 10:04 AM, jahanian <fjahanian at apple.com> wrote:
>> 
>>> LLVM IR times look within reasonable range. Also, please make sure what you are
>>> timing has @implementation of classes in them and preferably, with bunch of their 
>>> own private ivars.
>>> 
>> 
>> 
>> Building an entire application (that uses the feature) with “time”:
>> 
>> Baseline
>> ========
>> Debug+Asserts:
>> user	31m45.597s
>> 
>> Release
>> user	3m52.094s
>> 
>> with patch
>> ==========
>> Debug+Asserts:
>> user	31m35.599s
>> Release
>> user	3m52.637s
>> 
>> 
>> -- adrian





More information about the cfe-commits mailing list