r176275 - Fix a problem where 'clang' is ambiguous in MSVC builds.

David Blaikie dblaikie at gmail.com
Thu Feb 28 11:09:01 PST 2013


On Thu, Feb 28, 2013 at 11:07 AM, Manuel Klimek <klimek at google.com> wrote:
> 279>.\llvm\tools\clang\include\clang/AST/RecursiveASTVisitor.h(1715) : error
> C2872: 'clang' : ambiguous symbol
> 279>        could be 'clang'
> 279>        or       'clang::ento::clang'

Right, sorry - found it in the next email I read (for those following
along at home the context is in r176251)

clang::ento::clang?

Thinking aloud: Do we really have that namespace or is it something
MSVC is getting very confused about? If we have it, I assume we have
it by mistake & we should probably fix that mistake...

> 279>        .\llvm\tools\clang\include\clang/AST/RecursiveASTVisitor.h(1688)
> : while compiling class template member function 'bool
> clang::RecursiveASTVisitor<Derived>::TraverseFunctionHelper(clang::FunctionDecl
> *)'
> 279>        with
> 279>        [
> 279>            Derived=clang::ASTContext::ParentMapASTVisitor
> 279>        ]
> 279>        .\llvm\tools\clang\include\clang/AST/RecursiveASTVisitor.h(1840)
> : while compiling class template member function 'bool
> clang::RecursiveASTVisitor<Derived>::TraverseGCCAsmStmt(clang::GCCAsmStmt
> *)'
> 279>        with
> 279>        [
> 279>            Derived=clang::ASTContext::ParentMapASTVisitor
> 279>        ]
> 279>        .\llvm\tools\clang\include\clang/AST/RecursiveASTVisitor.h(522)
> : while compiling class template member function 'bool
> clang::RecursiveASTVisitor<Derived>::TraverseStmt(clang::Stmt *)'
> 279>        with
> 279>        [
> 279>            Derived=clang::ASTContext::ParentMapASTVisitor
> 279>        ]
> 279>        .\llvm\tools\clang\include\clang/AST/ASTContext.h(2202) : see
> reference to class template instantiation
> 'clang::RecursiveASTVisitor<Derived>' being compiled
> 279>        with
> 279>        [
> 279>            Derived=clang::ASTContext::ParentMapASTVisitor
> 279>        ]
> 275>   Creating library .\llvm\build\lib\Debug\clang-check.lib and object
> .\llvm\build\lib\Debug\clang-check.exp
> 2
>
>
> On Thu, Feb 28, 2013 at 8:06 PM, David Blaikie <dblaikie at gmail.com> wrote:
>>
>> On Thu, Feb 28, 2013 at 10:12 AM, Manuel Klimek <klimek at google.com> wrote:
>> > Author: klimek
>> > Date: Thu Feb 28 12:12:44 2013
>> > New Revision: 176275
>> >
>> > URL: http://llvm.org/viewvc/llvm-project?rev=176275&view=rev
>> > Log:
>> > Fix a problem where 'clang' is ambiguous in MSVC builds.
>>
>> um... just out of curiosity what was the ambiguity?
>>
>> >
>> > Modified:
>> >     cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>> >
>> > Modified: cfe/trunk/include/clang/AST/RecursiveASTVisitor.h
>> > URL:
>> > http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/RecursiveASTVisitor.h?rev=176275&r1=176274&r2=176275&view=diff
>> >
>> > ==============================================================================
>> > --- cfe/trunk/include/clang/AST/RecursiveASTVisitor.h (original)
>> > +++ cfe/trunk/include/clang/AST/RecursiveASTVisitor.h Thu Feb 28
>> > 12:12:44 2013
>> > @@ -1712,7 +1712,7 @@ bool RecursiveASTVisitor<Derived>::Trave
>> >    // FunctionNoProtoType or FunctionProtoType, or a typedef.  This
>> >    // also covers the return type and the function parameters,
>> >    // including exception specifications.
>> > -  if (clang::TypeSourceInfo *TSI = D->getTypeSourceInfo()) {
>> > +  if (TypeSourceInfo *TSI = D->getTypeSourceInfo()) {
>> >      TRY_TO(TraverseTypeLoc(TSI->getTypeLoc()));
>> >    }
>> >
>> >
>> >
>> > _______________________________________________
>> > cfe-commits mailing list
>> > cfe-commits at cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>



More information about the cfe-commits mailing list