[PATCH] Various additions to ASTMatcher library:

Manuel Klimek klimek at google.com
Mon Feb 25 12:03:39 PST 2013


  lg


================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3008
@@ +3007,3 @@
+/// \brief Matches declarations whose declaration context, cast to the
+/// appropriate Decl subtype, matches \c InnerMatcher.
+///
----------------
Since the cast is in the inner matcher, I'd leave it out here...

================
Comment at: unittests/ASTMatchers/ASTMatchersTest.cpp:3454
@@ +3453,3 @@
+    "N::M::D d;",
+    elaboratedType(hasQualifier(hasPrefix(specifiesNamespace(hasName("N")))))));
+}
----------------
We usually try to at least add one negative test for each atom (EXPECT_TRUE(notMatches(...))).


http://llvm-reviews.chandlerc.com/D460

BRANCH
  more_matchers

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list