[PATCH] Fix the return value of __builtin_eh_return_data_regno() for ARM and MIPS

Logan Chien tzuhsiang.chien at gmail.com
Fri Feb 22 20:25:53 PST 2013


Thanks for your your review.  Committed as r175954.


On Sat, Feb 23, 2013 at 7:33 AM, John McCall <rjmccall at apple.com> wrote:

> On Feb 22, 2013, at 3:50 AM, Logan Chien <tzuhsiang.chien at gmail.com>
> wrote:
> >   It seems that both ARMTargetInfo and MipsTargetInfoBase does not
> override getEHDataRegisterNumber(), thus __builtin_eh_return_data_regno()
> will always returns -1 on ARM and MIPS.  The patch should fix this issue,
> and the test cases are included.  Please have a look.  Thanks.
>
> Looks fine, assuming you have the register numbers right.
>
> John.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130223/8a639ba5/attachment.html>


More information about the cfe-commits mailing list