r175796 - Replace CFGElement llvm::cast support to be well-defined.

Ted Kremenek kremenek at apple.com
Fri Feb 22 16:10:10 PST 2013


On Feb 22, 2013, at 9:08 AM, Jordan Rose <jordan_rose at apple.com> wrote:

> My personal opinion on this is that we should actually remove the Invalid state from CFGStmt. It seems dangerous for exactly the reasons Ted has outlined.

Agreed.  If one has a CFGStmt it should be usable.  Period.  If there is an optimization trick we want to do to make Optional<CFGStmt> more efficient by stealing a bit from CFGStmt that's a different story, but the question of whether a CFGStmt is "valid" should not be something that can be queried by a client.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20130222/4a5a5cee/attachment.html>


More information about the cfe-commits mailing list